search

saurabhdaware / text-to-handwriting

So your teacher asked you to upload written assignments? Hate writing assigments? This tool will help you convert your text to handwriting xD
https://saurabhdaware.github.io/text-to-handwriting/
MIT License
4.71k stars 1.13k forks source link

New Featute : Dark mode #52

Closed harshilparmar closed 4 years ago

harshilparmar commented 4 years ago

I have tried #50.

Please let me know is it Ok or not? Correct me if I am wrong!!

EDIT: fixes #50

netlify[bot] commented 4 years ago

Deploy preview for text-to-handwriting processing.

Building with commit 50f2a86875bf9525b92aa1a536034df04f123fc9

https://app.netlify.com/sites/text-to-handwriting/deploys/5ef3a3a27f3f230007e31fb9

saurabhdaware commented 4 years ago

Thank you, Harshil! I haven't checked properly yet but can wo do something for this: Screenshot of dark mode toggle that shows it is being overlapped by github icon The toggle is not clickable because of that github icon

Maybe we can bring the toggle a little down (along with the content) so adding top padding to that main container should do the job.

Also maybe we can make the dark color a little darker and turn inputs dark as well.

You can refer to this CSS: https://github.com/abelljs/abell-starter-minima/blob/main/theme/styles/inlined/global.css.js

saurabhdaware commented 4 years ago

Oh and off-topic of this PR but your profile is not showing up in the commits and if you send PRs to repositories without that, even after getting PR merged your name won't show up in the contributors.

I guess its because email and name in your terminal is not configured or the email in your GitHub account is different from the one set in terminal.

Maybe try running git config --global user.email and see what email id it outputs and then set/add that email id in GitHub from https://github.com/settings/emails

harshilparmar commented 4 years ago

Thank you, Harshil! I haven't checked properly yet but can wo do something for this: Screenshot of dark mode toggle that shows it is being overlapped by github icon The toggle is not clickable because of that github icon

Maybe we can bring the toggle a little down (along with the content) so adding top padding to that main container should do the job.

Also maybe we can make the dark color a little darker and turn inputs dark as well.

You can refer to this CSS: https://github.com/abelljs/abell-starter-minima/blob/main/theme/styles/inlined/global.css.js

Ohh Thanks,I will change that.

harshilparmar commented 4 years ago

Yes! Looking great! Thank you @harshilparmar

Thanks bro!!! I want to ask some questions to you.Can I mail that or Can I ask here??

saurabhdaware commented 4 years ago

Wherever you're comfortable asking

My mail is: saurabhdaware99@gmail.com