search

saurabhdaware / text-to-handwriting

So your teacher asked you to upload written assignments? Hate writing assigments? This tool will help you convert your text to handwriting xD
https://saurabhdaware.github.io/text-to-handwriting/
MIT License
4.71k stars 1.13k forks source link

Added: Scanner effect #67

Closed pathakshashank17 closed 4 years ago

pathakshashank17 commented 4 years ago

I have decided to go with an effect of Shadow + 55% Contrast which looks close to scanned documents. Suggest changes if needed.

netlify[bot] commented 4 years ago

Deploy preview for text-to-handwriting processing.

Building with commit a21a32352faf520a50a4ba4718d3c50310145ee9

https://app.netlify.com/sites/text-to-handwriting/deploys/5f0718b51764fc00085a51a3

pathakshashank17 commented 4 years ago

About the first issue, that was an unintentional bug.

About the second issue, the problem that I was facing was that if I did not change document.querySelector('#page-effects').value to shadow, all the page rulings vanished. It was because of that I had to use another variable to store the current effect and then revert back to it afterwards so that scanner effect could be applied. Check this image

It would be helpful if you would point out the exact code which draws ruling on the pages.

pathakshashank17 commented 4 years ago

This looks amazing!

if I select 'scanner' effect and generate, it works great but when I select 'shadows' effect again, it still shows scanner effect in the output.

Also, What is exactly the need of window.altEffect? we can directly do document.querySelector('#page-effects').value no?

Ok, I have made the changes. Suggest changes.

pathakshashank17 commented 4 years ago

Looks perfect! Thank you so much, Shashank 🎉 This one of the coolest features we ever got!

Do you have twitter account which I can tag in a tweet? or maybe anything that I can help you promote?

Thanks!

Thanks a lot, I too learnt new things ! You can find me at Twitter or Instagram. Glad to be of help !