Closed mjarosie closed 4 years ago
Sorry for that PR I opened it by mistake. I'm just trying to play around with GitHub actions to see if I can contribute to one of the issues, I'll be doing it in my fork for now until I know it works.
@mjarosie Brilliant! Thank you. Let me know if you need any help. Head over to #46 if you'd like to discuss something about this issue/PR.
Following up the discussion about dev setup in #46: I'm not sure how detailed should the description be, I've made it quite brief for now - that can be extended when needed.
The CI is quite simple now - it just runs stack build
for a specific stack
version, should we stick to v2.3.3
or should we always build using the latest
of stack
?
Thank you @mjarosie . Can we set this up to run on all branches and commits?
@mjarosie it seems to be working after the merge. Check out https://github.com/saurabhnanda/odd-jobs/pull/43 - I had to close and reopen the PR for the CI to trigger.
I believe it should work automatically for all new PRs.
Thanks @mjarosie 👍
@mjarosie which of the steps showing up in https://github.com/saurabhnanda/odd-jobs/pull/43/checks?check_run_id=1197659802 will run every time this workflow/action runs? I hope stack + GHC installation will be skipped in the future.
@saurabhnanda awesome! I'm happy I could contribute! : ) Based on the logs of setup-haskell action in the CI run that you've linked it looks like it's caching Stack installation, hopefully if builds happen regularly the setup will be quicker:
I've also used cache action for caching ~/.stack
directory so pulling dependencies next time should be quicker as well.
Fixes #46
For now it's a very simple setup:
stack
only buildstack
versionI've also added a short developer setup description.