search

saurabhnanda / odd-jobs

Haskell job queue with admin UI and loads of other features.
https://www.haskelltutorials.com/odd-jobs/
BSD 3-Clause "New" or "Revised" License
75 stars 29 forks source link

Support GHC 9.0 and Aeson 2.0 #88

Closed tfausak closed 2 years ago

tfausak commented 2 years ago

https://github.com/saurabhnanda/odd-jobs/issues/86 https://github.com/saurabhnanda/odd-jobs/issues/85

saurabhnanda commented 2 years ago

I've been away from Haskell related for quite some months. What happened here? Why are these changes required?

tfausak commented 2 years ago

The changes to support GHC 9 relate to simplified subsumption. Starting with GHC 9, some things that used to type check now require adding a lambda in order to type check. See this Reddit thread for a lot of discussion: https://np.reddit.com/r/haskell/comments/ujpzx3/was_simplified_subsumption_worth_it_for_industry/

The changes to Aeson are necessary to support the new Key and KeyMap types that were introduced in version 2. I wrote a brief migration guide here: https://github.com/haskell/aeson/issues/881#issuecomment-944920664

saurabhnanda commented 2 years ago

What the.... can't we use some compiler flag to turn this nonsense off? Which committee does one need to be on to complain about this?

tfausak commented 2 years ago

You can find the original proposal here: https://github.com/ghc-proposals/ghc-proposals/pull/287

tchoutri commented 2 years ago

Hi, the Flora project is in need of a version of odd-jobs with support for GHC 9 and Aeson 2. How can I help to move this PR forward?

saurabhnanda commented 2 years ago

Hi, the Flora project is in need of a version of odd-jobs with support for GHC 9 and Aeson 2. How can I help to move this PR forward?

I was dragging my feet on this PR wishing that this subsumption nonsense would magically go-away with a new minor release of GHC, but I guess it's here to stay 😦