search

saurabhnemade / react-twitter-embed

Simplest way to add twitter widgets to your react project.
https://saurabhnemade.github.io/react-twitter-embed/
368 stars 66 forks source link

react-script and latest storybook dependencies not compatible #15

Closed saurabhnemade closed 5 years ago

saurabhnemade commented 6 years ago

Currently react-scripts 2.1.1 requires webpack 4.19.1 however storybook 4.x requires 4.23.1. Test cases are failing due to this.

Philip-Nunoo commented 5 years ago

I think I am having the same error with react-scripts 2.1.1 and storybook 4.x. @saurabhnemade any update on this.

saurabhnemade commented 5 years ago

@Philip-Nunoo I am still looking a way to get this working with latest storybook. As of now no any luck.

saurabhnemade commented 5 years ago

@Philip-Nunoo This has been resolved now. You can see the PR #26 . Somehow my changes are not reflected and build status is still showing wrong. Alternatively you can also take a look at branch https://github.com/saurabhnemade/react-twitter-embed/tree/sn-satyendra-master