search

sauravhathi / atsresume

ATSResume | Get hired with an ATS-optimized resume
https://atsresume.vercel.app
MIT License
254 stars 79 forks source link

No opting out of the vercel app footnote link #20

Open dmgolembiowski opened 4 months ago

dmgolembiowski commented 4 months ago

Regarding this:

https://github.com/sauravhathi/atsresume/blob/919d4cbf37491bc42af2e1fe15d70494eea800e1/styles/globals.css#L137

I get wanting to advertise the fruits of your labor, but not allowing an obvious opt-out on something people submit to prospective employers is not a good-faith practice. Would you accept a PR that at least binds this to a boolean value determined by a checkbox on the page? It could default to true.

sauravhathi commented 4 months ago

Thank you for bringing this up! We appreciate your feedback and suggestion. We would be open to a PR that implements the following changes:

  1. Introduces a boolean value that controls the visibility of the footnote link.
  2. Adds a checkbox on the page to allow users to opt-out of displaying the footnote link.
  3. The checkbox should default to true to maintain the current behavior unless the user chooses to opt-out.

Please ensure that the changes are well-documented and tested. We look forward to reviewing your contribution!