search

sausin / laravel-ovh

Wrapper for OVH Object Storage integration with laravel
MIT License
37 stars 12 forks source link

Fix laravel 6 compatibility #16

Closed wfeller closed 5 years ago

wfeller commented 5 years ago

Current composer.json prevents from updating to Laravel 6.1

sausin commented 5 years ago

@wfeller Merged the fix from @iksaku to include updates

wfeller commented 5 years ago

I don't know if that's the objective, but that fix is only going to work for Laravel 6.0, 6.1 and 6.2 (not 6.3 etc.), while my option would have worked for all 6.* versions...

I didn't invent anything, that's just how Spatie seems to do it : https://github.com/spatie/laravel-blink/blob/master/composer.json

sausin commented 5 years ago

If some breaking change comes in later revisions of Laravel, this package will just be updated to handle those changes and the new release will work.

At the same time, previous versions of the package won't fall apart as they will not get installed, prompting user to take some action.

It does make the composer.json long, but just taking a different route. Nothing 'wrong' with your PR :+1: