search

sausin / laravel-ovh

Wrapper for OVH Object Storage integration with laravel
MIT License
37 stars 12 forks source link

Change swiftSegmentSize config from string to int. #83

Closed jbeales closed 3 years ago

jbeales commented 3 years ago

When uploading a large object the swiftSegmentSize config option gets passed around until it gets used to create a GuzzleHttp\Psr7\LimitStream, where it must be an integer. Having it as a string causes a TypeError.

I'm not sure when this changed, everything was working fine for me, but I updated some dependencies today and must have pulled in a new version of of either sausin/laravel-ovh or php-opencloud/openstack, and now the types don't agree.

It might be logical to change the swiftLargeObjectThreshold as an integer too, but it is not causing any problems as a string so I didn't change it.

jbeales commented 3 years ago

Let's wait on this, it doesn't seem to have completely fixed my problem. I'll post back when I have figured out what's going on.

This was an error. I was using the wrong commit. The PR fixes the problem.

sausin commented 3 years ago

Thanks @jbeales !!