search

sausin / laravel-ovh

Wrapper for OVH Object Storage integration with laravel
MIT License
37 stars 12 forks source link

Laravel 9 upgrade #86

Closed wfeller closed 2 years ago

wfeller commented 2 years ago

@sausin please review

I've disabled https://github.com/BrainMaestro/composer-git-hooks for the time being

sausin commented 2 years ago

Given that we're dropping PHP 7.4, the package will have to be released as v7. If you could please also updated the README.md to indicate the new version with corresponding PHP version

I see that caching support had to be removed here. Is this going to be possible going forward? If not, then I would like to keep the cache text with a note that it's currently not available in 7.x

Rest looks good, thanks

wfeller commented 2 years ago

Done 👍

Yes, unfortunately caching is not supported anymore, see https://laravel.com/docs/9.x/upgrade "Flysystem no longer supports "cached adapters". Thus, they have been removed from Laravel and any relevant configuration (such as the cache key within disk configurations) can be removed."