search

savage13 / miniseed-rs

MiniSEED library for rust
MIT License
4 stars 3 forks source link

style #7

Open HerrMuellerluedenscheid opened 3 years ago

HerrMuellerluedenscheid commented 3 years ago

I saw that the pre-commit linting hook and the CI check was removed. I actually think that enforcing a standardized and recommended style accross all projects can increase code quality a lot and makes onboarding for new contributors much easier owed to the consistent style. I will continue using cargo fmt anyways because of that. In turn that means that if a preceeding commit did lint before committing that I will modify that part of code which has nothing to do with the commit that I'm about to make. That leads to increased git noise which will make the git history less readable.

So, what do you think @savage13 @acarapetis?

HerrMuellerluedenscheid commented 3 years ago

Going one step further I make heavy use of https://pre-commit.com/ in all of my projects. Saves a lot of time in that respect :)