search

savannabits / filament-signature-pad

Signature Pad Field for Filamentphp Forms
MIT License
63 stars 20 forks source link

[Bug]: Dom diffing issues? #19

Closed saade closed 1 year ago

saade commented 1 year ago

What happened?

On mouse up, an appears above the sign pad, and after that, everything breaks with no console errors.

How to reproduce the bug

Add the signature pad to a form

Package Version

LTS

PHP Version

8.2.x

Laravel Version

10.x

Which operating systems does with happen with?

macOS

Notes

https://github.com/savannabits/filament-signature-pad/assets/14329460/c0da1cd5-afc7-4823-a9c8-727a08323532

saade commented 1 year ago

Actually, it's not a DOM diffing issue, you display an image above the sign pad when the state is updated, because of that, the user can't release the mouse and continue signing (lift the pen).

I'm happy to create a PR to fix this, and a bit different API to allow more customizability