search

saveourtool / cosv4k

Kotlin and Java serialization schema for COSV
https://www.gitlink.org.cn/zone/CCF-ODC/source/7
MIT License
2 stars 0 forks source link

`Time_line` problems #9

Open orchestr7 opened 1 year ago

orchestr7 commented 1 year ago
  1. Mistake in spelling: should be not time_line, but timeline
  2. Timeline should not contain found and fixed types. As these types are already there in the events #8
JustinB1eber commented 1 year ago

Actually you can see the COSV-schema document, these already in the time_line examples. And current design can already meet the requirements.

"time_line": [
    {
      "type": "found",
      "value": "2023-02-13T16:43Z"
    },
    {
      "type": "fixed",
      "value": "2023-03-13T16:43Z"
    }
]
orchestr7 commented 1 year ago

As we discussed with @nulls disclosed type is the only actually type that cannot be calculated from events:

My suggestion to leave only disclosed in timeline by for now.

nulls commented 1 year ago

Also, as a simple enhancement, we can use format like in events: Instead of

"time_line": [
    {
      "type": "found",
      "value": "2023-02-13T16:43Z"
    },
    {
      "type": "fixed",
      "value": "2023-03-13T16:43Z"
    }
]

write

"time_line": [
    {
      "found": "2023-02-13T16:43Z"
    },
    {
      "fixed": "2023-03-13T16:43Z"
    }
]