Open 0x6675636b796f75676974687562 opened 1 year ago
we need also test spotless maven plugin
Sounds reasonable; our functionalTest
for Gradle plugin can be enhanced to run different scenarios as well as projects with spotless
plugin using Gradle testkit.
Update: we already have Gradle plug-in tests available under
diktat-gradle-plugin/src/functionalTest/
,so the primary focus of this task is the Spotless plug-in (see below).
Diktat Gradle plug-in
Probably
DiktatJavaExecTaskTest
, feel free to suggest a different test class name../gradlew diktatCheck
) against invalid input should produce errors fromdiktat-ruleset
namespace.plain
reportersarif
reporterKtLint
-standard rules are indeed excluded, i. e. none of the errors from thestandard
orexperimental
namespaces are triggered by the invalid input (be sure to also disable the corresponding Diktat rules viadiktat-analysis.yml
). This test should fail if changes from #1568 are temporarily rolled back.Spotless Gradle plug-in
plain
reportersarif
reporterBasically, we need a test which would, one way or another, launch a forked JVM against a test project, something we do in
DiktatSmokeTest
.At the same time, I'd vote against using
save-cli
for this purpose and instead look for smth similar to khmarbaise/maven-it-extension for JUnit 5, for two reasons:save-cli
takes a long time to download over a slow network,@petertrr, @nulls, WDYT?