saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
521 stars 39 forks source link

Fixed StatelessClassesRule #1741

Closed nulls closed 11 months ago

nulls commented 11 months ago

What's done:

It's part of #1737

codecov[bot] commented 11 months ago

Codecov Report

Merging #1741 (92a3be6) into master (dd5542b) will increase coverage by 0.12%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1741      +/-   ##
============================================
+ Coverage     75.00%   75.12%   +0.12%     
  Complexity     2274     2274              
============================================
  Files           126      126              
  Lines          8233     8233              
  Branches       2066     2067       +1     
============================================
+ Hits           6175     6185      +10     
+ Misses         1142     1132      -10     
  Partials        916      916              
Files Changed Coverage Δ
...set/rules/chapter6/classes/StatelessClassesRule.kt 83.72% <100.00%> (+23.25%) :arrow_up:
nulls commented 11 months ago

btw, why ktlint start to run itself for 3 times? we cant change this behavior?

yes, ktlint start to run itseft and 3 times is hardcoded unfortunately

nulls commented 11 months ago

btw, why ktlint start to run itself for 3 times? we cant change this behavior?

but here the problem is in copyElement. Kotlin 1.9 doesn't allow it