saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
521 stars 39 forks source link

Fixed IdentifierNaming #1746

Closed nulls closed 11 months ago

nulls commented 11 months ago

What's done:

It's part of #1737

github-actions[bot] commented 11 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 21s :stopwatch: - 2m 12s 1 378 tests ±0  1 317 :heavy_check_mark: +3  61 :zzz:  - 3  0 :x: ±0  2 757 runs  ±0  2 695 :heavy_check_mark: +3  62 :zzz:  - 3  0 :x: ±0 

Results for commit 1e41d015. ± Comparison against base commit feeeee9d.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 11 months ago

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   7m 12s :stopwatch: -31s 1 378 tests ±0  1 329 :heavy_check_mark: +3  49 :zzz:  - 3  0 :x: ±0  2 757 runs  ±0  2 707 :heavy_check_mark: +3  50 :zzz:  - 3  0 :x: ±0 

Results for commit 1e41d015. ± Comparison against base commit feeeee9d.

:recycle: This comment has been updated with latest results.

kgevorkyan commented 11 months ago

so many broken tests, why we are even update ktlint to 1.0 before release of diktat 😬

nulls commented 11 months ago

so many broken tests, why we are even update ktlint to 1.0 before release of diktat 😬

we upgraded ktlint to 1.0 to have a release version in diktat 2.0

codecov[bot] commented 11 months ago

Codecov Report

Merging #1746 (1e41d01) into master (feeeee9) will increase coverage by 0.08%. The diff coverage is 84.21%.

@@             Coverage Diff              @@
##             master    #1746      +/-   ##
============================================
+ Coverage     75.94%   76.02%   +0.08%     
+ Complexity     2282     2281       -1     
============================================
  Files           126      126              
  Lines          8234     8242       +8     
  Branches       2068     2069       +1     
============================================
+ Hits           6253     6266      +13     
+ Misses         1063     1060       -3     
+ Partials        918      916       -2     
Files Changed Coverage Δ
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt 80.95% <84.21%> (+1.24%) :arrow_up:

... and 1 file with indirect coverage changes