saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
519 stars 39 forks source link

Support configuration of reporters in DSL #1808

Closed nulls closed 8 months ago

nulls commented 8 months ago

What's done:

It closes #1801

github-actions[bot] commented 8 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files   - 1     164 suites   - 1   9m 26s :stopwatch: + 2m 13s 1 393 tests  - 2  1 357 :heavy_check_mark:  - 2  36 :zzz: ±0  0 :x: ±0  2 772 runs   - 2  2 736 :heavy_check_mark:  - 2  36 :zzz: ±0  0 :x: ±0 

Results for commit 37f7420e. ± Comparison against base commit 81a74293.

This pull request removes 2 tests. ``` com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default reporter type value() com.saveourtool.diktat.plugin.gradle.ReporterSelectionTest ‑ should fallback to plain reporter for unknown reporter types() ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 8 months ago

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files   - 1     164 suites   - 1   7m 5s :stopwatch: +8s 1 393 tests  - 2  1 376 :heavy_check_mark:  - 2  17 :zzz: ±0  0 :x: ±0  2 772 runs   - 2  2 755 :heavy_check_mark:  - 2  17 :zzz: ±0  0 :x: ±0 

Results for commit 37f7420e. ± Comparison against base commit 81a74293.

This pull request removes 2 tests. ``` com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default reporter type value() com.saveourtool.diktat.plugin.gradle.ReporterSelectionTest ‑ should fallback to plain reporter for unknown reporter types() ```

:recycle: This comment has been updated with latest results.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (81a7429) 78.33% compared to head (37f7420) 78.39%.

Files Patch % Lines
.../diktat/plugin/gradle/extension/DefaultReporter.kt 79.59% 10 Missing :warning:
...urtool/diktat/plugin/gradle/extension/Reporters.kt 57.14% 9 Missing :warning:
...ourtool/diktat/ktlint/DiktatReporterFactoryImpl.kt 0.00% 9 Missing :warning:
.../saveourtool/diktat/plugin/maven/DiktatBaseMojo.kt 0.00% 8 Missing :warning:
...lin/com/saveourtool/diktat/cli/DiktatProperties.kt 0.00% 7 Missing :warning:
...diktat/plugin/gradle/tasks/SarifReportMergeTask.kt 50.00% 6 Missing :warning:
...rtool/diktat/plugin/gradle/tasks/DiktatTaskBase.kt 96.42% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1808 +/- ## ============================================ + Coverage 78.33% 78.39% +0.06% - Complexity 2421 2432 +11 ============================================ Files 126 128 +2 Lines 8488 8578 +90 Branches 2152 2151 -1 ============================================ + Hits 6649 6725 +76 - Misses 879 893 +14 Partials 960 960 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.