saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
516 stars 39 forks source link

Support running diktat without configuration #1837

Closed nulls closed 7 months ago

nulls commented 7 months ago

What's done:

It closes #1833

github-actions[bot] commented 7 months ago

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 49s :stopwatch: +5s 1 402 tests ±0  1 385 :heavy_check_mark: ±0  17 :zzz: ±0  0 :x: ±0  2 781 runs  ±0  2 764 :heavy_check_mark: ±0  17 :zzz: ±0  0 :x: ±0 

Results for commit 6f020652. ± Comparison against base commit 137b4f7b.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. ``` com.saveourtool.diktat.test.ConfigReaderTest ‑ testing json reading() com.saveourtool.diktat.test.ConfigReaderTest ‑ testing kotlin version() ``` ``` com.saveourtool.diktat.ruleset.config.DiktatRuleConfigYamlReaderTest ‑ testing json reading() com.saveourtool.diktat.ruleset.config.DiktatRuleConfigYamlReaderTest ‑ testing kotlin version() ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 17s :stopwatch: -58s 1 402 tests ±0  1 366 :heavy_check_mark: ±0  36 :zzz: ±0  0 :x: ±0  2 781 runs  ±0  2 745 :heavy_check_mark: ±0  36 :zzz: ±0  0 :x: ±0 

Results for commit 6f020652. ± Comparison against base commit 137b4f7b.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. ``` com.saveourtool.diktat.test.ConfigReaderTest ‑ testing json reading() com.saveourtool.diktat.test.ConfigReaderTest ‑ testing kotlin version() ``` ``` com.saveourtool.diktat.ruleset.config.DiktatRuleConfigYamlReaderTest ‑ testing json reading() com.saveourtool.diktat.ruleset.config.DiktatRuleConfigYamlReaderTest ‑ testing kotlin version() ```

:recycle: This comment has been updated with latest results.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (137b4f7) 78.18% compared to head (6f02065) 78.42%.

Files Patch % Lines
...rtool/diktat/ruleset/config/CommonConfiguration.kt 76.00% 2 Missing and 4 partials :warning:
...t/ruleset/config/AbstractDiktatRuleConfigReader.kt 71.42% 3 Missing and 1 partial :warning:
.../saveourtool/diktat/plugin/maven/DiktatBaseMojo.kt 0.00% 3 Missing :warning:
...lin/com/saveourtool/diktat/cli/DiktatProperties.kt 0.00% 1 Missing :warning:
...rtool/diktat/plugin/gradle/tasks/DiktatTaskBase.kt 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1837 +/- ## ============================================ + Coverage 78.18% 78.42% +0.24% - Complexity 2425 2434 +9 ============================================ Files 131 133 +2 Lines 8631 8617 -14 Branches 2174 2171 -3 ============================================ + Hits 6748 6758 +10 + Misses 917 897 -20 + Partials 966 962 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.