Fixed bug related to assigning to declared vals inside null-check branches

saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs

https://diktat.saveourtool.com

MIT License

516 stars 39 forks source link

Fixed bug related to assigning to declared vals inside null-check branches #1851

Closed DrAlexD closed 7 months ago

DrAlexD commented 7 months ago

What's done:

Fixed bug related to case when if-else block inside init or run, with, apply blocks and there is more than one statement inside else block. This case leads to kotlin compilation error after adding run block instead of else block. Read https://youtrack.jetbrains.com/issue/KT-64174 for more information.
Added new warning tests.

Closes #1844

codecov[bot] commented 7 months ago

Files	Patch %	Lines
...ol/diktat/ruleset/rules/chapter4/NullChecksRule.kt	92.30%	0 Missing and 3 partials :warning:

```diff @@ Coverage Diff @@ ## master #1851 +/- ## ============================================ + Coverage 78.42% 78.44% +0.01% - Complexity 2442 2455 +13 ============================================ Files 133 133 Lines 8632 8644 +12 Branches 2179 2184 +5 ============================================ + Hits 6770 6781 +11 Misses 896 896 - Partials 966 967 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 7 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

  164 files ±0   164 suites ±0 8m 11s :stopwatch: + 2m 57s 1 412 tests +4 1 376 :heavy_check_mark: +4 36 :zzz: ±0 0 :x: ±0 2 791 runs +4 2 755 :heavy_check_mark: +4 36 :zzz: ±0 0 :x: ±0

Results for commit d9d97c9b. ± Comparison against base commit 0390093a.

:recycle: This comment has been updated with latest results.