saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
525 stars 39 forks source link

Support ANT-like glob patterns #1856

Closed nulls closed 9 months ago

nulls commented 9 months ago

What's done:

It closes #1854

codecov[bot] commented 9 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c20f2d5) 78.42% compared to head (ac5ced8) 78.54%.

Files Patch % Lines
...ain/kotlin/com/saveourtool/diktat/util/CliUtils.kt 87.87% 0 Missing and 4 partials :warning:
...lin/com/saveourtool/diktat/cli/DiktatProperties.kt 0.00% 1 Missing :warning:
...otlin/com/saveourtool/diktat/ktlint/KtLintUtils.kt 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1856 +/- ## ============================================ + Coverage 78.42% 78.54% +0.11% Complexity 2456 2456 ============================================ Files 133 133 Lines 8641 8654 +13 Branches 2185 2189 +4 ============================================ + Hits 6777 6797 +20 + Misses 894 883 -11 - Partials 970 974 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 9 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   4m 17s :stopwatch: - 4m 2s 1 419 tests +5  1 382 :heavy_check_mark: +4  37 :zzz: +1  0 :x: ±0  2 798 runs  +5  2 761 :heavy_check_mark: +4  37 :zzz: +1  0 :x: ±0 

Results for commit 11b1222e. ± Comparison against base commit c20f2d5e.

This pull request removes 4 and adds 9 tests. Note that renamed tests count towards both. ``` com.saveourtool.diktat.util.CliUtilsKtTest ‑ walkByGlobWithEmptyResult(Path) com.saveourtool.diktat.util.CliUtilsKtTest ‑ walkByGlobWithGlobalPath(Path) com.saveourtool.diktat.util.CliUtilsKtTest ‑ walkByGlobWithLeadingAsterisks(Path) com.saveourtool.diktat.util.CliUtilsKtTest ‑ walkByGlobWithRelativePath(Path) ``` ``` com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithEmptyResult() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithFolder() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithGlobalPath() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithGlobalPattern() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithLeadingAsterisks() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithNegative() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithParentFolder() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithRelativePath() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithRelativePathWindows() ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 9 months ago

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   7m 11s :stopwatch: +2s 1 419 tests +5  1 402 :heavy_check_mark: +5  17 :zzz: ±0  0 :x: ±0  2 798 runs  +5  2 781 :heavy_check_mark: +5  17 :zzz: ±0  0 :x: ±0 

Results for commit 11b1222e. ± Comparison against base commit c20f2d5e.

This pull request removes 4 and adds 9 tests. Note that renamed tests count towards both. ``` com.saveourtool.diktat.util.CliUtilsKtTest ‑ walkByGlobWithEmptyResult(Path) com.saveourtool.diktat.util.CliUtilsKtTest ‑ walkByGlobWithGlobalPath(Path) com.saveourtool.diktat.util.CliUtilsKtTest ‑ walkByGlobWithLeadingAsterisks(Path) com.saveourtool.diktat.util.CliUtilsKtTest ‑ walkByGlobWithRelativePath(Path) ``` ``` com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithEmptyResult() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithFolder() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithGlobalPath() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithGlobalPattern() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithLeadingAsterisks() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithNegative() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithParentFolder() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithRelativePath() com.saveourtool.diktat.util.CliUtilsKtTest ‑ listByFilesWithRelativePathWindows() ```

:recycle: This comment has been updated with latest results.