search

saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
516 stars 39 forks source link

Added script for Windows #1859

Closed nulls closed 7 months ago

nulls commented 7 months ago

What's done:

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (73cd9a7) 78.39% compared to head (e8ff9f6) 78.42%.

Files Patch % Lines
...ourtool/diktat/ktlint/DiktatReporterFactoryImpl.kt 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1859 +/- ## ============================================ + Coverage 78.39% 78.42% +0.03% Complexity 2456 2456 ============================================ Files 133 133 Lines 8645 8641 -4 Branches 2184 2185 +1 ============================================ Hits 6777 6777 + Misses 898 894 -4 Partials 970 970 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 7 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 17s :stopwatch: -27s 1 414 tests ±0  1 378 :heavy_check_mark: ±0  36 :zzz: ±0  0 :x: ±0  2 793 runs  ±0  2 757 :heavy_check_mark: ±0  36 :zzz: ±0  0 :x: ±0 

Results for commit e8ff9f61. ± Comparison against base commit 73cd9a78.

github-actions[bot] commented 7 months ago

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 56s :stopwatch: -4s 1 414 tests ±0  1 397 :heavy_check_mark: ±0  17 :zzz: ±0  0 :x: ±0  2 793 runs  ±0  2 776 :heavy_check_mark: ±0  17 :zzz: ±0  0 :x: ±0 

Results for commit e8ff9f61. ± Comparison against base commit 73cd9a78.

0x6675636b796f75676974687562 commented 7 months ago

As was recently discovered, there may be two instances of bash.exe on a typical workstation:

image

We can use one or the other.

nulls commented 7 months ago

As was recently discovered, there may be two instances of bash.exe on a typical workstation:

  • The one from MSys Git, typically %ProgramFiles%\Git\usr\bin\bash.exe
  • The one from WSL (if WSL is installed): %windir%\system32\bash.exe. This one starts the default WSL distribution if one isn't running, and has wslhost.exe as the child process:

image

We can use one or the other.

I think The one from MSys Git, typically %ProgramFiles%\Git\usr\bin\bash.exe is better (current behavior), since it runs Java on Windows instead of WSL