Closed diphtongue closed 11 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
02c1a7c
) 78.55% compared to head (5b479d8
) 78.54%.
Files | Patch % | Lines |
---|---|---|
.../diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt | 73.68% | 0 Missing and 5 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
164 files ±0 164 suites ±0 7m 37s :stopwatch: +7s 1 423 tests +4 1 406 :heavy_check_mark: +4 17 :zzz: ±0 0 :x: ±0 2 802 runs +4 2 785 :heavy_check_mark: +4 17 :zzz: ±0 0 :x: ±0
Results for commit 5b479d8d. ± Comparison against base commit 02c1a7cc.
:recycle: This comment has been updated with latest results.
164 files ±0 164 suites ±0 5m 17s :stopwatch: -12s 1 423 tests +4 1 386 :heavy_check_mark: +4 37 :zzz: ±0 0 :x: ±0 2 802 runs +4 2 765 :heavy_check_mark: +4 37 :zzz: ±0 0 :x: ±0
Results for commit 5b479d8d. ± Comparison against base commit 02c1a7cc.
:recycle: This comment has been updated with latest results.
Discussed offline, lets cover with tests following cases
1) There shouldnt be any warning in:
try {
// ...
throw(ex1)
// ...
} catch(ex1) {
} catch(ex2) {
} catch(ex3)
2) There shouldnt be any warning in:
try {
// ...
throw NumberException
// ...
} catch(IlligalArgumentException) {
since NumberException is child of IlligalArgumentException
3) We should warn in this case
try {
// ...
throw(ex1)
// ...
throw(ex2)
throw(ex3)
} catch(ex1) {
} catch(ex2) {
}
ex3
here is not catched , so we need add @throws ex3
What's done:
KDOC_WITHOUT_THROWS_TAG
rule when it adds a @throws annotation to the function, which hasthrow
inside try-catch blockCloses #1718