search

saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
516 stars 38 forks source link

Fixed `PARAMETER_NAME_IN_OUTER_LAMBDA` #1882

Closed nulls closed 6 months ago

nulls commented 6 months ago

What's done:

It closes #1251

codecov[bot] commented 6 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a0c564e) 78.30% compared to head (bf9b1a7) 78.30%.

Files Patch % Lines
...ool/diktat/ruleset/rules/chapter4/SmartCastRule.kt 27.27% 8 Missing :warning:
...urtool/diktat/ruleset/rules/chapter3/LineLength.kt 50.00% 0 Missing and 1 partial :warning:
...at/ruleset/rules/chapter3/files/IndentationRule.kt 75.00% 1 Missing :warning:
...m/saveourtool/diktat/ruleset/utils/AstNodeUtils.kt 88.88% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1882 +/- ## ========================================= Coverage 78.30% 78.30% Complexity 2465 2465 ========================================= Files 134 134 Lines 8699 8699 Branches 2202 2202 ========================================= Hits 6812 6812 Misses 905 905 Partials 982 982 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   166 files  ±0     166 suites  ±0   11m 41s :stopwatch: + 7m 41s 1 430 tests +4  1 392 :heavy_check_mark: +4  38 :zzz: ±0  0 :x: ±0  2 809 runs  +4  2 771 :heavy_check_mark: +4  38 :zzz: ±0  0 :x: ±0 

Results for commit 9d0c2c64. ± Comparison against base commit 0063c8ba.

This pull request removes 7 and adds 11 tests. Note that renamed tests count towards both. ``` com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check all param in config true() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore numbers in test(Path) com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore top level constants() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check value parameter in function with config() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check value parameter with config() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check value parameter() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ simple check() ``` ``` com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check all() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore companion object property declaration() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore constant declaration() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore enums() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore extension functions() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore hash code function() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore local variable declaration() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore pairs created using 'to'() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore property declaration() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore ranges() … ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 months ago

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   166 files  ±0     166 suites  ±0   7m 22s :stopwatch: -10s 1 430 tests +4  1 413 :heavy_check_mark: +4  17 :zzz: ±0  0 :x: ±0  2 809 runs  +4  2 792 :heavy_check_mark: +4  17 :zzz: ±0  0 :x: ±0 

Results for commit 9d0c2c64. ± Comparison against base commit 0063c8ba.

This pull request removes 7 and adds 11 tests. Note that renamed tests count towards both. ``` com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check all param in config true() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore numbers in test(Path) com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore top level constants() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check value parameter in function with config() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check value parameter with config() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check value parameter() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ simple check() ``` ``` com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check all() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore companion object property declaration() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore constant declaration() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore enums() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore extension functions() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore hash code function() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore local variable declaration() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore pairs created using 'to'() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore property declaration() com.saveourtool.diktat.ruleset.chapter3.MagicNumberRuleWarnTest ‑ check ignore ranges() … ```

:recycle: This comment has been updated with latest results.