saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
516 stars 38 forks source link

Fixed false positive findings [PARAMETER_NAME_IN_OUTER_LAMBDA] #1891

Closed diphtongue closed 6 months ago

diphtongue commented 6 months ago

What's done:

Closes #1880

github-actions[bot] commented 6 months ago

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

  166 files  ±0    166 suites  ±0   8m 22s :stopwatch: +16s 1 438 tests +5  1 400 :white_check_mark: +5  38 :zzz: ±0  0 :x: ±0  2 818 runs  +5  2 780 :white_check_mark: +5  38 :zzz: ±0  0 :x: ±0 

Results for commit 7b990fe2. ± Comparison against base commit 8636247d.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 months ago

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

  166 files  ±0    166 suites  ±0   7m 27s :stopwatch: -25s 1 438 tests +5  1 421 :white_check_mark: +5  17 :zzz: ±0  0 :x: ±0  2 818 runs  +5  2 801 :white_check_mark: +5  17 :zzz: ±0  0 :x: ±0 

Results for commit 7b990fe2. ± Comparison against base commit 8636247d.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (8636247) 78.28% compared to head (7b990fe) 78.27%.

Files Patch % Lines
...m/saveourtool/diktat/ruleset/utils/AstNodeUtils.kt 35.71% 1 Missing and 8 partials :warning:
...t/rules/chapter5/ParameterNameInOuterLambdaRule.kt 78.57% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1891 +/- ## ============================================ - Coverage 78.28% 78.27% -0.01% - Complexity 2471 2478 +7 ============================================ Files 134 134 Lines 8712 8724 +12 Branches 2210 2216 +6 ============================================ + Hits 6820 6829 +9 - Misses 905 906 +1 - Partials 987 989 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.