search

saveourtool / diktat

Strict coding standard for Kotlin and a custom set of rules for detecting code smells, code style issues and bugs
https://diktat.saveourtool.com
MIT License
516 stars 38 forks source link

ci: Do not run code coverage on forks #1900

Closed marcospereira closed 5 months ago

marcospereira commented 6 months ago

What?

Disable code coverage uploading when running on forks. This is useful so that contributors can enable GitHub Actions on their forks without having false negatives due to lack of codecov configuration.

Which rule and warnings did you add?

None.

Actions checklist

orchestr7 commented 5 months ago

Thanks for reviewing, @akuleshov7. I replied with a few questions.

lgtm, I am trying to understand why CI has freezes (today GitHub had outage)

orchestr7 commented 5 months ago

Reopened PR to restart CI actions

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (435e499) 78.27% compared to head (66e231f) 78.26%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1900 +/- ## ============================================ - Coverage 78.27% 78.26% -0.02% Complexity 2478 2478 ============================================ Files 134 134 Lines 8724 8724 Branches 2216 2216 ============================================ - Hits 6829 6828 -1 - Misses 906 907 +1 Partials 989 989 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marcospereira commented 5 months ago

Thank you, @akuleshov7. It seems this is good to go now. :-)

orchestr7 commented 5 months ago

@marcospereira merged, thank you for contribution!