search

saveourtool / save-cloud

Cluster-based cloud mechanism for running SAVE framework
https://cosv.gitlink.org.cn
MIT License
38 stars 3 forks source link

Pagination doesn't work in Execution history #1574

Closed nulls closed 1 year ago

nulls commented 1 year ago

https://saveourtool.com/#/CQFN.org/Diktat-Integration/history

page button is clickable, but nothing happens. count button doesn't work too

petertrr commented 1 year ago

Might've been broken in #1488

kgevorkyan commented 1 year ago

@petertrr does it worked at all before? I see, that we didn't used usePageSelection useServerPaging arguments for tableComponent, and also getPageCount = null

petertrr commented 1 year ago

I vaguely remember using server paging only in tables where large number of rows was expected and client-side paging for others. Maybe, HistoryView was among the latter. Still, there is a pageIndex, setPageIndex, which is always passed to pagingControl

kgevorkyan commented 1 year ago

Seems, that it's really breaks after migration to react table v8. However, the answer is not on the surface - there are some recommendations, to set the flag autoResetPageIndex to false, but it didn't helped.

Components, which uses client side paginations does not worked, moreover, pageIndex changed correctly under hood, but page doesn't actually changed

kgevorkyan commented 1 year ago

Data from state seems to be updated correctly, however it doesn't influent to client side pagination, it's not worked. The configuring of several flags of tableInstance gives no results for now