search

savi-lang / savi

A fast language for programmers who are passionate about their craft.
BSD 3-Clause "New" or "Revised" License
155 stars 12 forks source link

Add Platform methods for BSD distros #338

Open tonchis opened 1 year ago

tonchis commented 1 year ago

@jemc I made this a draft because I see there are many tasks in the CI failing and didn't wanna merge with a broken pipeline. The ubuntu and macOS builds are passing, but since this is a BSD specific change it'd be nice to see it passing on such machine.

mneumann commented 1 year ago

love it!

jemc commented 1 year ago

Yes, looks like we have multiple CI issues to address, both with an Alpine version upgrade and a Crystal version upgrade.

None of them are likely to be related to this PR.

I will aim to make time today to get the pipeline green again.

jemc commented 1 year ago

I have a PR that should hopefully resolve the breakages for the existing CI jobs.

I agree with you that it would be nice to have FreeBSD CI working.

In particular, we won't be able to run FreeBSD CI for any of the libraries unless/until we get it working here for the main Savi build.

I did some work on a FreeBSD CI job a while back, but it's currently commented out because it's not working. I believe the key obstacle was that I couldn't get the latest version of Crystal installed on the FreeBSD CI runner - the existing "FreeBSD port" was pinned to an older version.

@mneumann (who uses FreeBSD) may have ideas about how to get past that obstacle.

jemc commented 1 year ago

Looking at https://www.freshports.org/lang/crystal/ I see that it looks like it includes the latest Crystal version (1.5.0) so it may be doable now. I'll create another branch to try to get FreeBSD CI up and running.

jemc commented 1 year ago

The above mentioned PR is merged, and here's a working PR to add a FreeBSD CI job: https://github.com/savi-lang/savi/pull/340

jemc commented 1 year ago

I've rebased this PR on latest main, which should resolve the CI failures.