search

saviorand / lightbug_http

Simple and fast HTTP framework for Mojo! 🔥
MIT License
567 stars 36 forks source link

Add packaging workflow #27

Closed Moosems closed 6 months ago

Moosems commented 7 months ago

Fixes #25

Moosems commented 7 months ago

You will need to create a secret key for it that allows it to create releases and copy the code from the repository with the name TOKEN

saviorand commented 6 months ago

@Moosems just pushed a commit to main that should fix the packaging issue you were having. See a couple small edits below: basically I think we can just use the default GITHUB_TOKEN for the release job with write permissions, no need for a custom token. Tested this on a private copy of the main repo and it works. Can you explain why the modular auth examples works for authenticating with modular? 😄 this is very surprising to me. Otherwise, with these small changes should be good to merge

Moosems commented 6 months ago

@saviorand I don't know why it works. Its how they did it in the Modular/mojo workflows and it just works so I chose not to question it

saviorand commented 6 months ago

I assume it uses some existing token. I could also pass my own token as an env variable

saviorand commented 6 months ago

Thanks a lot for the contribution! Merged