savioserra / vs-theme-switcher

:waxing_crescent_moon: Schedule themes in Visual Studio Code! :sun_with_face:
https://marketplace.visualstudio.com/items?itemName=savioserra.theme-switcher
13 stars 2 forks source link

Not working?! #7

Closed TheDevelolper closed 4 years ago

TheDevelolper commented 4 years ago

Hi there,

I set a theme switch for 12:00 GMT (UTC+0)

The switch didn't happen.

here's a copy of my settings:


{
    "vscode_custom_css.imports": [
        "https://raw.githubusercontent.com/robb0wen/synthwave-vscode/master/synthwave84.css"
    ],
    "vscode_custom_css.policy": true,
    "editor.fontFamily": "JetBrains Mono",
    "editor.fontLigatures": true,
    "themeswitcher.utcOffset": 0, // Example
    "themeswitcher.mappings": [
        {
            "time": "08:00",
            "theme": "snazzy Light",
        },
        {
            "time": "12:00",
            "theme": "Material Theme Darker High Contrast",
        },
        {
            "time": "17:00",
            "theme": "Horizon",
        },
        {
            "time": "20:00",
            "theme": "Outrun Electric",
        },
    ],
    "peacock.favoriteColors": [
        {
            "name": "Angular Red",
            "value": "#b52e31"
        },
        {
            "name": "Auth0 Orange",
            "value": "#eb5424"
        },
        {
            "name": "Azure Blue",
            "value": "#007fff"
        },
        {
            "name": "C# Purple",
            "value": "#68217A"
        },
        {
            "name": "Gatsby Purple",
            "value": "#639"
        },
        {
            "name": "Go Cyan",
            "value": "#5dc9e2"
        },
        {
            "name": "Java Blue-Gray",
            "value": "#557c9b"
        },
        {
            "name": "JavaScript Yellow",
            "value": "#f9e64f"
        },
        {
            "name": "Mandalorian Blue",
            "value": "#1857a4"
        },
        {
            "name": "Node Green",
            "value": "#215732"
        },
        {
            "name": "React Blue",
            "value": "#00b3e6"
        },
        {
            "name": "Something Different",
            "value": "#832561"
        },
        {
            "name": "Vue Green",
            "value": "#42b883"
        }
    ],
    "python.dataScience.askForKernelRestart": false,
    "typescript.updateImportsOnFileMove.enabled": "always",
    "editor.largeFileOptimizations": false,
    "editor.formatOnSave": true,
    "synthwave84.brightness": 1,
    "window.zoomLevel": 0,
    "git.enableSmartCommit": true,
    "workbench.iconTheme": "vscode-icons",
    "javascript.updateImportsOnFileMove.enabled": "always",
    "readTime.enabled": true,
    "explorer.confirmDelete": false,
    "dashboard.projectData": null,
    "chronicler.ffmpeg-binary": "d:\\Tools\\ffmpeg/ffmpeg.exe",
    "explorer.confirmDragAndDrop": false,
    "workbench.startupEditor": "none",
    "editor.fontSize": 18,
    "dart.debugExternalLibraries": false,
    "dart.debugSdkLibraries": false,
    "dart.openDevTools": "flutter",
    "editor.suggestSelection": "first",
    "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
    "workbench.colorTheme": "snazzy Light"
}
TheDevelolper commented 4 years ago

Update! I was being stupid. It does work but here in the UK we're currently in BST not GMT! DUH!

So It updated and hour later than expected. Would be good if this could read from the system clock so that I don't have to update it

savioserra commented 4 years ago

Hi @ISimplifyComplexity , thank you for reporting.

At first I was thinking about the extension reading from the system clock, but there was an unexpected behavior within the VS Code Extension Host. The problem was related to daylight saving times. So to get rid of it I decided to let the user decide which utc offset works for him.

soupdiver commented 10 months ago

At first I was thinking about the extension reading from the system clock, but there was an unexpected behavior within the VS Code Extension Host. The problem was related to daylight saving times. So to get rid of it I decided to let the user decide which utc offset works for him.

Same happened to me... my local time and remotes hosts time are 8:30 CET but the switcher wouldn't change the theme.. The UTC offset setting probably works technically but then I have to change that in summer time etc. just feels a bit wonky. Not sure what's the unexpected behaviour when it comes to reading the system time but dates/time can be hard in computer world :D Still would love the extension to use my local time and not UTC with an offset.

@savioserra