search

savoirfairelinux / ansible-nexus3-oss

Ansible role to provision Nexus Repository Manager 3.x for RedHat/CentOS
https://galaxy.ansible.com/savoirfairelinux/nexus3-oss/
GNU General Public License v3.0
113 stars 96 forks source link

Adding Docker,Pypi, Raw, NPM, Bower repository options [ false by default ], move templates/groovy -> files/groovy #5

Closed hagzag closed 7 years ago

hagzag commented 7 years ago

@samherve will appreciate your input on this PR ASAP.

samherve commented 7 years ago

Hi @hagzag , all my apologies for the feedback delay ; I just checked this, and it looks fine to me. I couldn't test all the proxies types though, but I guess that if Nexus creates them it should work.

I'll add a "nexus_config_maven" flag just like you did for the other repo types, it makes sense now that the provisionning is not maven-only anymore.

I had a question also : is there any particular reason why you did not add the "raw-hosted" repo type ?

Thanks a lot for this PR, I'm merging this and updating the ansible-galaxy role straight-away !

hagzag commented 7 years ago

@samherve well the raw hosted didn't make any sense to me ... it sounds like any web server hosting a website no ? any way it is probably 5 minutes of work if you find value in that lets go for it !