savoirfairelinux / ansible-nexus3-oss

Ansible role to provision Nexus Repository Manager 3.x for RedHat/CentOS
https://galaxy.ansible.com/savoirfairelinux/nexus3-oss/
GNU General Public License v3.0
113 stars 96 forks source link

Feature configure properties #6

Closed remyma closed 7 years ago

remyma commented 7 years ago

Add ability to configure default nexus properties : /opt/nexus-latest/nexus-default.properties

remyma commented 7 years ago

Hello, did you see my changes ? Does it look good now ?

Regards

samherve commented 7 years ago

Hello, apologize for the late answer, I tested this PR and the role fails when calling nexus REST API whith the default value for nexus_default_context_path: '/', most probably due to a double '//' in the resulting URL.

Did you run the role with the default value without any issue ? It all seemed fine with an empty string here though nexus_default_context_path: '' .

remyma commented 7 years ago

Ok. Sorry, I did not see this problem because testing with nexus_default_context_path: '/nexus'.

I kept nexus_default_context_path: '/' as this because it is the default value provided by nexus but I removed the '/' in rest url to make it work.

To override nexus_default_context_path you have to keep the '/' at the end. The correct value for context path in my previous example should now be: nexus_default_context_path: '/nexus/'

I have tested it with default and override value and it works.

samherve commented 7 years ago

Thank you, I tested this OK. The patch is merged, released and pushed to ansible galaxy !

remyma commented 7 years ago

Thank you ;-)

2017-02-13 15:31 GMT+01:00 Samuel Hervé notifications@github.com:

Thank you, I tested this OK. The patch is merged, released and pushed to ansible galaxy !

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/savoirfairelinux/ansible-nexus3-oss/pull/6#issuecomment-279407623, or mute the thread https://github.com/notifications/unsubscribe-auth/ACL7_w6V-iuMaTH4LqVVTDiRgax1-vs0ks5rcGklgaJpZM4L4eZf .