savoirfairelinux / cqfd

cqfd helps running commands inside the Docker container configured for your project, keeping the user and working directory the same inside the container
GNU General Public License v3.0
64 stars 31 forks source link

Use $1 and $* instead of "$@" #113

Closed joufellasfl closed 9 months ago

joufellasfl commented 9 months ago

The function docker_run() takes a single argument as the command string, but it uses "$@". Therefore, $1 is enough and it should be used instead to avoid confusion.

The shell expression "$@" expands to an array string, but the "$@" is assigned to the scalar (i.e. non-array) variable build_cmd_alt; Therefore, $* should be used instead.

This uses $1 and $* instead of "$@" at some places.