search

savoirfairelinux / cqfd

cqfd helps running commands inside the Docker container configured for your project, keeping the user and working directory the same inside the container
GNU General Public License v3.0
65 stars 31 forks source link

cqfd: add the run -c argument #86

Closed dupremathieu closed 2 years ago

dupremathieu commented 2 years ago

Except for the default flavor command, do not override the command defined in flavor by the one given with the run argument. Instead concatenate the two command.

JGrossholtz commented 2 years ago

What does "runp" stands for ? run ... ? Can be usefull.

kevlhop commented 2 years ago

What does "runp" stands for ? run ... ? Can be usefull.

I changed the name of the command to runc, which could mean "run the concatenation".

joufella commented 2 years ago

I'm not a fan of the "runc" approach. First, it makes little sense to me having different verbs that both end up running a command. Second, it becomes confusing with regards to the runc command. A simple adaptation that would work for me is to add an option to the "run" verb.

Common tools (like docker which cqfd is a frontend to) use this semantics: docker run vs. docker run -e var=val (and not docker runenv). So i'd be in for an argument base approach to passing parameters, eg. cqfd run -p arg1 argN.. instead of cqfd runc arg1 argN.., at this point this should be a relatively minor change.

dupremathieu commented 2 years ago

I'm not opposed to use -p argument, but why "p" and not "c" for concatenate?