savoirfairelinux / cqfd

cqfd helps running commands inside the Docker container configured for your project, keeping the user and working directory the same inside the container
GNU General Public License v3.0
65 stars 31 forks source link

Handle special characters in usernames #92

Closed eroussy closed 1 year ago

eroussy commented 1 year ago

Despite Linux warnings, some people may have username containing '@' or '$' characters. Such characters are incompatible with the docker tag system and causes bugs later in cqfd. To avoid future headaches, this commit formats the docker tag to use only letters, digits, underscores and dashes.

Note: cqfd launches a useradd command at the start of the docker container. On some distributions, this command will fail if the username contains such characters. This commits doesn't handle this problem.

joufella commented 1 year ago

PR is now merged.