search

savoirfairelinux / cqfd

cqfd helps running commands inside the Docker container configured for your project, keeping the user and working directory the same inside the container
GNU General Public License v3.0
65 stars 31 forks source link

Add custom image name support. #96

Closed mchaplet closed 8 months ago

mchaplet commented 1 year ago

This option allows to use a custom name for docker image. It thus allows to create and/or pull images to/from a private docker repository.

joufella commented 1 year ago

Thanks @mchaplet this looks like a nice improvement! This commit was adapted a bit and rebased on top of the latest master changes in the branch devel/custom_image_name.

Please have a look at it, I didn't merge it yet as I see two potential concerns:

  1. I would like to have test coverage for this new feature. Would you be able to add a test case (see tests/)? If not let me know and I'll be able to get you some help.
  2. I didn't play with it too much but I'd like to be sure it plays well with other features such as flavors (-b). Probably this should be covered in the previous point too.

EDIT: pressed enter too fast.

mchaplet commented 11 months ago

Hi Jérôme,

CQFD is a great, simple and efficient tool but actually, for my needs, I moved on gitlabci-local.

It's clearly 'heavier' (thanks python) but does a great job around configuration (.yml), multiples jobs/flavors, variables and even if it can be used without gitlab server, it allows ready-to-use local build and server CI. (few tip: it also support podman integration, which match my needs regarding user rights, i.e. avoid creating 'root' files in my work directory)

TL;DR: feel free to close this PR or keep/rewrite it for your own needs.

joufellasfl commented 11 months ago

Thanks for your feedback, Martin, that's very interesting actually. Podman support has been in our thoughts for a while, and I like the idea of storing both the image def + build config in a single file. Maybe we should evolve towards that, it would make sense to use/support Gitlab's CI schema.

joufellasfl commented 8 months ago

Thank you Martin, merged this PR.