savoirfairelinux / mod-influxdb

Shinken module for exporting data to InfluxDB
GNU Affero General Public License v3.0
13 stars 11 forks source link

Better series name #13

Closed gst closed 9 years ago

gst commented 9 years ago

NB NB : Changed serie items separator to '>'.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+28.02%) when pulling 2640df4527e34a06a73c9f8c5b4db5b02619b706 on better_series_name into ba7210255f8c81961dea541a09b4ba4d931da0bf on master.

aviau commented 9 years ago

I'll be taking a look at this Thursday. Thanks!

coveralls commented 9 years ago

Coverage Status

Coverage increased (+28.02%) when pulling 42dd5a992aa3d082675408989a221f1660638eff on better_series_name into ba7210255f8c81961dea541a09b4ba4d931da0bf on master.

gst commented 9 years ago

last little modif. after reread of myself. but shouldn't hurt you as it is really subtle :p ;)

aviau commented 9 years ago

I like the new series naming, but I think that the new brok tests should have been in a separate PR (atleast a separate commit so it's more readable). They don't send the good types of brok so they should fail.

plus... they are all log broks.

For reference:

gst commented 9 years ago

seems I forgot to finish the tests ;)

aviau commented 9 years ago

I'm working on them right now. Wait till you're back in the office :P

aviau commented 9 years ago

@gst I'll merge all tests that make sense, and we can work on the others later.