Closed gst closed 9 years ago
I'll be taking a look at this Thursday. Thanks!
last little modif. after reread of myself. but shouldn't hurt you as it is really subtle :p ;)
I like the new series naming, but I think that the new brok tests should have been in a separate PR (atleast a separate commit so it's more readable). They don't send the good types of brok so they should fail.
plus... they are all log broks.
For reference:
{'time_stamp': 1234567890, 'return_code': '2', 'host_name': 'test_host_0', 'output': 'Bob is not happy', 'perf_data': 'rtt=9999'}
{'host_name': 'test_host_0', 'time_stamp': 1234567890, 'service_description': 'test_ok_0', 'return_code': '1', 'output': 'Bobby is not happy', 'perf_data': 'rtt=9999;5;10;0;10000'}
seems I forgot to finish the tests ;)
I'm working on them right now. Wait till you're back in the office :P
@gst I'll merge all tests that make sense, and we can work on the others later.
NB NB : Changed serie items separator to '>'.