search

savoirfairelinux / mod-influxdb

Shinken module for exporting data to InfluxDB
GNU Affero General Public License v3.0
13 stars 11 forks source link

Delete duplicate SERVICE_ALERT, HOST_ALERT #9

Open titilambert opened 10 years ago

titilambert commented 10 years ago

Hello !

I just try this module, I saw duplicate event in _events_:

time sequence_number alert_type attempts state_type state output
1414537758000 4180001 SERVICE 1 HARD OK SSH OK - OpenSSH_6.6.1p1 Ubuntu-2ubuntu2 (protocol 2.0)
1414537757000 4190001 HARD OK SSH OK - OpenSSH_6.6.1p1 Ubuntu-2ubuntu2 (protocol 2.0)
1414536258000 290001 HARD CRITICAL Connection refused
1414536258000 280001 SERVICE 1 HARD CRITICAL Connection refused
1414536199000 30001 SERVICE 1 SOFT CRITICAL Connection refused
1414536198000 40001 SOFT CRITICAL Connection refused

Delete this lines correct this. BUT maybe there is some side effects. What do you think about ?

Anyway, we have to think about Travis tests and.

coveralls commented 10 years ago

Coverage Status

Coverage increased (+1.24%) when pulling 53a7d46104054fb019145414ae26a2ea67a38e9a on titilambert:delete_duplication into 0fb6e84aefb36c27f473a7e80dbfbfa1ca7723aa on savoirfairelinux:master.

titilambert commented 10 years ago

Oups, We have aleady some tests ! So we need more tests !