search

savoirfairelinux / num2words

Modules to convert numbers to words. 42 --> forty-two
GNU Lesser General Public License v2.1
820 stars 497 forks source link

Add Breton language support #452

Open dancergraham opened 2 years ago

dancergraham commented 2 years ago

Closes #447 by implementing Breton language support

Changes proposed in this pull request:

Status

How to verify this change

Run the tests - the new features are fully tested and the tox tests pass for all Python versions on Github CI

Additional notes

The Breton language is a celtic language taught in many schools in Brittany, north-west France.

dancergraham commented 2 years ago

Hello, do I need to increase test coverage to 100% for this?

mrodriguezg1991 commented 2 years ago

Hello, do I need to increase test coverage to 100% for this?

I think yes, the test fails under the 100%

dancergraham commented 1 year ago

Hello, I have increased the test coverage to 100% - this should be OK to merge now !

dancergraham commented 1 year ago

hmm - I don't understand why this is failing on CI but passed with 100% coverage on my Windows machine. The CI output seems to show 100% coverage for the Breton Language in the list of all tests and then 96% coverage in the subsequent failure summary. I will have a look at whether I am running the coverage commands properly locally