Add Amharic language support

savoirfairelinux / num2words

Modules to convert numbers to words. 42 --> forty-two

GNU Lesser General Public License v2.1

820 stars 497 forks source link

Add Amharic language support #464

Closed devEyosiyas closed 2 years ago

devEyosiyas commented 2 years ago

Fixes # by Eyosiyas Bereketab

Changes proposed in this pull request:

Fix line too long init.py

Status

[X] READY
[ ] HOLD
[ ] WIP (Work-In-Progress)

mrodriguezg1991 commented 2 years ago

@devEyosiyas Thanks for your contribution Can you increase the test coverage and fix the flake 8 requirements in python3.10 ? Thanks

devEyosiyas commented 2 years ago

Will do.

On Mon, Aug 8, 2022, 3:55 PM Marlon Rodriguez Garcia < @.***> wrote:

@devEyosiyas https://github.com/devEyosiyas Thanks for your contribution Can you increase the test coverage and fix the flake 8 requirements in python3.10 ? Thanks

— Reply to this email directly, view it on GitHub https://github.com/savoirfairelinux/num2words/pull/464#issuecomment-1208092148, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOCH7OZOXWSPWAEOH75T4VLVYD7VPANCNFSM5527YWQQ . You are receiving this because you were mentioned.Message ID: @.***>

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2825836774

78 of 83 (93.98%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 96.307%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
num2words/lang_AM.py	47	52	90.38%
<!--	Total:	78	83	93.98%	-->

Totals
Change from base Build 2799420615:	-0.04%
Covered Lines:	6908
Relevant Lines:	7096