Closed jheinecke closed 6 months ago
Hi, is there any action needed from me ? checks seemed to have passed successfully :-)
Hi, is there any action needed from me ? checks seemed to have passed successfully :-)
Hi, sorry for the delay, seems to be some conflicts with the main branch, can you fix it, pls? Thanks
I resolved the conflict. Should be OK now
Fixes # by Johannes Heinecke
Changes proposed in this pull request:
support of two new languages
Status
How to verify this change
run tests for Welsh and Chechen
Additional notes
Welsh
I needed Welsh for a personal project. I also added Chechen since was on it.
The Welsh function has two additional arguments:
gender
(valid valuesfem
ormasc
) and the counted object. The latter is needed since in Welsh the counted object does not follow the number (like English seventeen dogs) but is inserted within the numeric expression:e.g.
num2words(17, lang="cy", counted="ci", gender="masc")
Currencies are used in the same way
E.g.
num2words(31.50, lang='cy', to="currency", currency="GBP")
After a numeral the noun is always in Singular
Chechen
The Chechen API as also two language specific arguments,
case
(valid values:abs
,gen
,dat
,erg
,instr
,mat
,comp
,all
,obl
,attr
) and the semantic class (gender). The casesobl
is needed when the numeral is used with a noun in non-Absolute Case,attr
is needed (only internally) if the numeral precedes another numeral (ши бӀе == 2 * 100). All other cases are used if the numeral is used as a noun (Tree are coming
) Chechen has 6 classes (genders) which are marked by 4 letters ("д", "б", "й" or "в".Adjectives, numerals and verbs agree with the noun in class. In case of numerals it is only 4, 14, 40, 80 which show the class letter. If not given "д" is used:
e.g.
num2words(4, lang='ce', case="abs", clazz="в")