savoirfairelinux / ringme.js

A library to display a « Ring Me » button on a website.
https://frama.link/ringme
GNU General Public License v3.0
4 stars 14 forks source link

Detection issues under Chrome #18

Closed peakwinter closed 7 years ago

peakwinter commented 7 years ago

Expected Behaviour

While using Chrome, the URI scheme detection should work properly from the first page load.

Actual Behaviour

While using Chrome, the URI scheme does not appear to be detected until the user clears a "Ring presence is unknown" alert at least once.

Steps to reproduce

Notes

At the point where the alert window is opened, this.isRingSchemeSupported() returns false. But on subsequent attempts in the same browser session, it returns true. It's just this first run that either has a false detection or doesn't prevent the window from launching when the user clicks Cancel.

ssirois commented 7 years ago

Thanks to @samnegri and the #Hacktoberfest event, this issue is now fix.