Add parameters for specifying button defaults and images. - Githubissues

savoirfairelinux / ringme.js

A library to display a « Ring Me » button on a website.

https://frama.link/ringme

GNU General Public License v3.0

4 stars 14 forks source link

Add parameters for specifying button defaults and images. #19

Closed peakwinter closed 7 years ago

peakwinter commented 7 years ago

(May not fix, but at least partially addresses #3.)

Changes proposed in this pull request:

Add several parameters to RingMe.ui() for customizing button creation:
- buttonImage: specify an image URL to use as a button instead of plaintext.
- buttonClass: manually override the classes used on the <a> link.
- buttonLabel: manually override the default button text.
Add a default button image.

Status

[X] READY
[ ] HOLD
[ ] WIP (Work-In-Progress)

How to verify this change

Open the test page.
Check out the default image being used as a button.
Edit the call to RingMe.ui() as done in the <script> tag of tests/ringme.html to use some of the new options specified above.

Additional notes

none

ventilooo commented 7 years ago

:+1:

ssirois commented 7 years ago

@peakwinter I just created a pull request on your branch to make sure this does not create a barrier to an accessible button.

Merge it inside your branch to get those changes here and feel free to improve my suggestion.