volume souschef_static is unused

savoirfairelinux / sous-chef

Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.

GNU Affero General Public License v3.0

67 stars 45 forks source link

volume souschef_static is unused #763

Closed kousu closed 7 years ago

kousu commented 7 years ago

docker-compose.yml defines

   volumes:
      - souschef_static:/code/src/static

but staticfiles are placed under /code/src/sous_chef/static, as far as I can tell. This folder here is unused, and unfound by Django when looking for things under /static.

lingxiaoyang commented 7 years ago

I think it is completely safe to remove this volume from Docker file. @erozqba How do you think?

erozqba commented 7 years ago

@kousu @lingxiaoyang is not safe to remove this volume and it is being used by the Nginx in the production settings to serve static files directly without the intervention of Gunicorn. This is not an issue right now, so I'm closing it. We should probably discuss the way we use "gulp" and "collecstatic" in a separated issue.