search

savoirfairelinux / sous-chef

Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.
GNU Affero General Public License v3.0
67 stars 45 forks source link

Display Version Number #766

Closed kousu closed 7 years ago

kousu commented 7 years ago

I have a request: can we please add the git revision and/or tag onto the footer or the login page?

lingxiaoyang commented 7 years ago

@lamontfr Have we talked about this once, maybe in a face-to-face meeting? If so, can you remind me of the specific reason that we decided not to add the commit id?

Sorry I don't remember it anymore. If we've never discussed about it, I would agree with this proposal and it's not difficult to do.

kousu commented 7 years ago

I just noticed too that SOUSCHEF_VERSION= seems to be printed in the sidebar, but that's manually set by an environment variable, and it's not the revision number.

lingxiaoyang commented 7 years ago

@kousu Yes, exactly. You can see #743.

lamontfr commented 7 years ago

@kousu @lingxiaoyang I opened issue #743 for this purpose. Issue #766 is a duplicate.

@kousu Please edit docker-compose.yml in sous-chef-Test as per the deployment notes in PR #754. SOUSCHEF_ENVIRONMENT_NAME=TEST; If you want you can set SOUSCHEF_VERSION=v1.0-beta3-a7c7068.

kousu commented 7 years ago

I'll take this debate to #743.