search

savoirfairelinux / sous-chef

Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.
GNU Affero General Public License v3.0
67 stars 45 forks source link

Sticky Footer #773

Closed erozqba closed 7 years ago

erozqba commented 7 years ago

Make the footer stick to the bottom when there is not enough content.

Fixes # by erozqba

Changes proposed in this pull request:

Status

How to verify this change

Run docker-compose exec web sh -c "cd tools/gulp && gulp" to regenerate the assets.

Deployment notes and migration

New translatable strings

Additional notes

If applicable, explain the rationale behind your change.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 95.379% when pulling 49be274147c3dade28e92f8c1f7a608df612be03 on erozqba:sticky-footer into bbc3954976e06c7be5a947f3fb03560b203e5b44 on savoirfairelinux:dev.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 95.326% when pulling 10188bf554b48815fdaf6315f7c98977f4d343b2 on erozqba:sticky-footer into bbc3954976e06c7be5a947f3fb03560b203e5b44 on savoirfairelinux:dev.

erozqba commented 7 years ago

@lingxiaoyang Could you test it again? I have committed some changes. Thanks in advance.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 95.328% when pulling d88aadb0320b58abb21fbe8f279aa6ce391543dc on erozqba:sticky-footer into 4a795a0e4e4756ca4a148ed78646ec77ad193684 on savoirfairelinux:dev.

lingxiaoyang commented 7 years ago

@erozqba Verified. Thank you!