savoirfairelinux / sous-chef

Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.
GNU Affero General Public License v3.0
67 stars 45 forks source link

Run test in Travis-CI using Docker #775

Closed erozqba closed 7 years ago

erozqba commented 7 years ago

Fixes #758 by erozqba

Changes proposed in this pull request:

Status

How to verify this change

Check Travis-CI build.

Deployment notes and migration

New translatable strings

Additional notes

If applicable, explain the rationale behind your change.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 95.353% when pulling 07ac23b8607a28582769d24f56828024ec795356 on erozqba:issue_758 into bbc3954976e06c7be5a947f3fb03560b203e5b44 on savoirfairelinux:dev.

erozqba commented 7 years ago

@lingxiaoyang I have managed to make coveralls work inside the docker container, we have to pass some environment variables of TravisCI.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 95.326% when pulling f48cc2acff540620522c556e93b27a1c85945426 on erozqba:issue_758 into bbc3954976e06c7be5a947f3fb03560b203e5b44 on savoirfairelinux:dev.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 95.405% when pulling 58839450df1846acfa06ada13f1ddff705859d48 on erozqba:issue_758 into bbc3954976e06c7be5a947f3fb03560b203e5b44 on savoirfairelinux:dev.

lingxiaoyang commented 7 years ago

@erozqba Cool! Thank you for investigating the travis variables!

I think you included some changes of PR #762. We'll have to see if there's any change of #762 that is not included here, for example, (maybe) documentation.

erozqba commented 7 years ago

@lingxiaoyang I have included the changes of PR #762 that I found we must have as soon as possible, for the other changes we can continue the discussion in PR #762. I have made a rebase over dev to fix the conflicts.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 95.357% when pulling 7e75542dd1249d4dc382b0afbf4cb460936ca4f0 on erozqba:issue_758 into fe4c262474869f9a4567f9aa4e1507b99bcc668f on savoirfairelinux:dev.