Use nginx container only with in prod settings.

erozqba commented 7 years ago

Fixes by erozqba

Changes proposed in this pull request:

Use nginx container only with in prod settings, because we don't really need for development.

Status

[X] READY
[ ] HOLD
[ ] WIP (Work-In-Progress)

How to verify this change

docker-compose down
docker-compose up -d
docker-compose ps

The last command should only show two containers running, web and mariadb.

Deployment notes and migration

[ ] Migration is needed for this change

New translatable strings

[ ] If applicable, I have included updated .po files with new strings (see https://github.com/savoirfairelinux/sous-chef/blob/dev/docs/internationalization.adoc)

Additional notes

If applicable, explain the rationale behind your change.

coveralls commented 7 years ago

Coverage increased (+0.01%) to 95.342% when pulling 4562c9821f6bfc4b752e2cc1042c7673019c2db8 on erozqba:use_ngixn_in_prod_only into 2e8df857438b155d09fa0989bef77121a3682e2d on savoirfairelinux:dev.

coveralls commented 7 years ago

Coverage remained the same at 95.328% when pulling 4562c9821f6bfc4b752e2cc1042c7673019c2db8 on erozqba:use_ngixn_in_prod_only into 2e8df857438b155d09fa0989bef77121a3682e2d on savoirfairelinux:dev.

erozqba commented 7 years ago

@lamontfr you could ask Nick to also verify this? Thanks in advance!

erozqba commented 7 years ago

After 21 days whitout any review, I will accept this myself because this is only docker-compose configuration and not a python/django related code. If something get broken I will fix it.

savoirfairelinux / sous-chef