Add extension in the phone number format error message - Githubissues

savoirfairelinux / sous-chef

Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.

GNU Affero General Public License v3.0

67 stars 45 forks source link

Add extension in the phone number format error message #794

Closed lamontfr closed 7 years ago

lamontfr commented 7 years ago

Fixes #787

The phone number format with extensions accepted by the application is XXX-XXX-XXXX # XXXXX but the error message was misleading because it said that phone numbers must be in format XXX-XXX-XXXX.

Changes proposed in this pull request:

src/member/formsfield.py : override django.contrib.localflavors CAPhoneNumberField default error message.
src/member/locale/fr/LC_MESSAGES/django.po : added message and its french translation.

Status

[X] READY

How to verify this change

Client / Choose client / Client Relationships / Edit / Create new member / type work phone number with wrong format (i.e. 514-876-9876 ext 1234) / Save : should see the error message that shows the required format.

New translatable strings

[X] If applicable, I have included updated .po files with new strings (see https://github.com/savoirfairelinux/sous-chef/blob/dev/docs/internationalization.adoc)

coveralls commented 7 years ago

Coverage increased (+0.01%) to 95.408% when pulling 1b2a08299eb4d52d2d72e10fec641fdc88c15748 on lamontfr:fix787 into 9bd445a679fe23f7aacc57f11b8d2807211b3bdc on savoirfairelinux:dev.