Allow blank mid and rid for member

savoirfairelinux / sous-chef

Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.

GNU Affero General Public License v3.0

67 stars 45 forks source link

Allow blank mid and rid for member #799

Closed lamontfr closed 7 years ago

lamontfr commented 7 years ago

Fixes #796.

Changes proposed in this pull request:

src/member/models.py : allow blank values

Status

[X] READY

How to verify this change

Admin / Members / select a member X / check that Mid or Rid is blank / enter some text in work information / Save / see message "The member "X" was changed successfully."

coveralls commented 7 years ago

Coverage decreased (-0.03%) to 95.33% when pulling 73052300ad389fb0c5ea9532467d4f9f1740b720 on lamontfr:fix796 into 059669041764a3ea965b848a49ffe7cdf34babab on savoirfairelinux:dev.

erozqba commented 7 years ago

Hi @lamontfr I think you are missing a migration file, you have modified the member model, so you should have a migration field generated, not?

About the migrations, there are another PR #792 that already add some missing migrations, I suggest to review and merge #792 first.

lamontfr commented 7 years ago

@erozqba You are right. I am closing this PR and will make a new one so that the migrations are sequential.