Add field relationships to member.Client

savoirfairelinux / sous-chef

Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.

GNU Affero General Public License v3.0

67 stars 45 forks source link

Add field relationships to member.Client #804

Closed lamontfr closed 7 years ago

lamontfr commented 7 years ago

Fixes #793

Changes proposed in this pull request:

src/member/models.py : Client model
src/member/migrations/0035_client_relationships.py : client table

Status

[X] READY

How to verify this change

Clients / click list display icon at top right / scroll to bottom of page / Export / see downloaded .CSV file.

Deployment notes and migration

[X] Migration is needed for this change

coveralls commented 7 years ago

Coverage increased (+0.09%) to 95.396% when pulling 6bd1714c2b724c0820c4d19377a428ee5d2d1863 on lamontfr:fix793 into 6c27f2afeeb16b1916d6179a2d956e61170e1560 on savoirfairelinux:dev.

erozqba commented 7 years ago

Hi @lamontfr I have tested your changes, but I think that a different solution would be more appropriated. There is already a relationship between the Client and the Relationship models, so we don't really need to add another one, we should only use the existent, please look at the PR #806.

lamontfr commented 7 years ago

@erozqba Thanks for your review and your better solution. I merged your PR #806.