Fixed #803: order to create must not be empty - Githubissues

savoirfairelinux / sous-chef

Sous-Chef is a web application to help organizations to plan and deliver meals, and to manage clients files.

GNU Affero General Public License v3.0

67 stars 45 forks source link

Fixed #803: order to create must not be empty #807

Closed lingxiaoyang closed 6 years ago

lingxiaoyang commented 7 years ago

Fixes #803 by lingxiaoyang

Changes proposed in this pull request:

While validating the order batch creation form, for each delivery date, check if quantities and three checkboxes are all empty. If so, highlight these forms as red, and prevent the form submission.

A small JS change is needed to flush the checkbox errors on newly selected dates.

Status

[x] READY
[ ] HOLD
[ ] WIP (Work-In-Progress)

How to verify this change

Merge and gulp
Go to order batch creation form, select client, select a date, set size, and submit the form. You should then see error indication on the quantity fields and checkboxes.
Try back-and-forth with more dates.

Deployment notes and migration

none

New translatable strings

[x] If applicable, I have included updated .po files with new strings (see https://github.com/savoirfairelinux/sous-chef/blob/dev/docs/internationalization.adoc)

Additional notes

none

lingxiaoyang commented 6 years ago

Updated in d770098:

coveralls commented 6 years ago

Changes Unknown when pulling d770098b4245206a37d730b802d98f3e35c18045 on lingxiaoyang:fix_803 into on savoirfairelinux:dev.